CIP-0129 support #4879
Merged
CIP-0129 support #4879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly
force-pushed
the
paweljakubas/adp-4855/cip-0129
branch
from
7941ae8 to
74b0689
Compare
paweljakubas
force-pushed
the
paweljakubas/adp-4855/cip-0129
branch
from
c147de1 to
a1de81e
Compare
Note that we spent time trying to have a unique DRep keys schema representing both keys and scripts hashes but for reasons unknown to the mere mortals, bump.sh kept rejecting our changes hence why we resorted to keeping the 2 types but with identical underlying representations.
abailly
force-pushed
the
paweljakubas/adp-4855/cip-0129
branch
from
8fae5bd to
be83ff0
Compare
paweljakubas
force-pushed
the
paweljakubas/adp-4855/cip-0129
branch
from
67e2085 to
8b5d36d
Compare
abailly
approved these changes
Dec 13, 2024
| textDecodingError = TextDecodingError $ unwords | ||
| [ "Invalid DRep Script hash: expecting a Bech32 encoded value" | ||
| , "with human readable part of 'drep_script'." | ||
| textFirstByteError = TextDecodingError $ unwords |
There was a problem hiding this comment.
Do we want to have concrete error messages in a Primitive library? Perhaps it would be better to have some type and let consumers define their own messages?
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
… work accomplished in this PR. Before you submit, don't forget to: CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project configs docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml justfile lib nix prototypes reports run scripts specifications test touch.me.CI weeder.dhall Make sure the GitHub PR fields are correct: ✓ Set a good Title for your PR. ✓ Assign yourself to the PR. ✓ Assign one or more reviewer(s). ✓ Link to a Jira issue, and/or other GitHub issues or PRs. ✓ In the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project configs docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml justfile lib nix prototypes reports run scripts specifications test touch.me.CI weeder.dhall Don't waste reviewers' time: ✓ If it's a draft, select the Create Draft PR option. ✓ Self-review your changes to make sure nothing unexpected slipped through. CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project configs docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml justfile lib nix prototypes reports run scripts specifications test touch.me.CI weeder.dhall Try to make your intent clear: ✓ Write a good Description that explains what this PR is meant to do. ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding Jira ticket. ✓ Highlight what Testing you have done. ✓ Acknowledge any changes required to the Documentation. --> The PR adds support for https://github.com/cardano-foundation/CIPs/tree/master/CIP-0129 It adds specified in CIP-0129 prefixes for drep in case of script and key hash credentials. The change required to remove `drep_script` HRP that was used preciously for drep script hashes. All unit tests, generators therein and golden data was regenerated. ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number fix #4855 <!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles. Note: Jira issues of the form ADP- will be auto-linked. --> Source commit: 53d41a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds support for https://github.com/cardano-foundation/CIPs/tree/master/CIP-0129
It adds specified in CIP-0129 prefixes for drep in case of script and key hash credentials.
The change required to remove
drep_scriptHRP that was used preciously for drep script hashes.All unit tests, generators therein and golden data was regenerated.
Comments
Issue Number
fix #4855