Add errSameVote to responsesConstructTransaction in swagger

[paweljakubas]

• errSameVote is used in error specification of responsesJoinStakePool and responsesJoinDRep but was missing in responsesConstructTransaction
• We add also the guard in constructTransaction
• Checking in integration testing

Comments

Issue Number

fix #4870

[abailly]

Looks good to me, some suggestion to clarify code a bit and separate IO from checks but feel free to ignore

[abailly]

Suggested change

	if isJust voted then
	pure ()
	else
	throwE ErrConstructTxWithdrawalWithoutVoting
	unless (isJust voted) $ throwE ErrConstructTxWithdrawalWithoutVoting

[paweljakubas]

done

[abailly]

Suggested change

	votingM <- liftIO $ atomically (getCurrentVoting walletState)
	case votingM of
	Nothing ->
	pure ()
	Just currentDrep -> case votingActionM of
	Nothing ->
	pure ()
	Just (VoteRegisteringKey requestedDrep) ->
	cmpDReps currentDrep requestedDrep
	Just (Vote requestedDrep) ->
	cmpDReps currentDrep requestedDrep
	_ -> pure ()
	where
	cmpDReps cDrep rDRep =
	when (cDrep == rDRep) $ throwE $ ErrConstructTxVoting ErrWrongEra
	liftIO (atomically $ getCurrentVoting walletState) >>= checkVotingIsDifferent votingActionM
	_ -> pure ()
	checkVotingIsDifferent :: Monad m => Maybe VotingAction -> Maybe DRep -> ExceptT ErrConstructTx m ()
	checkVotingIsDifferent votingActionM = \case
	Nothing ->
	pure ()
	Just currentDrep -> case votingActionM of
	Nothing ->
	pure ()
	Just vote -> checkDRepIsDifferent currentDrep (getDRep vote)
	where
	getDRep = \case
	VoteRegisteringKey requestedDrep -> requestedDrep
	Vote requestedDrep -> requestedDrep
	checkDRepIsDifferent cDrep rDRep =
	when (cDrep == rDRep) $ throwE $ ErrConstructTxVoting ErrWrongEra

[abailly]

Seems to me cleaner as we separate the IO action of extracting some data from the DB with checking it. It could be good to make checkVotingIsDifferent pure and then move it somewhere else and unit test it but perhaps overkill for now.

[paweljakubas]

good suggestions, done. Thanks