Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(segmented-control): [DSM-800] add tests #792

Merged
merged 6 commits into from
Oct 6, 2023
Merged

feat(segmented-control): [DSM-800] add tests #792

merged 6 commits into from
Oct 6, 2023

Conversation

jpcav21
Copy link
Contributor

@jpcav21 jpcav21 commented Oct 2, 2023

What

Added new tests to assert segmented control functions
Refactored previously developed tests

Code Quality Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • I have updated storybook (if appropriate)

Jira Card

DSM-800

@jpcav21 jpcav21 requested a review from a team as a code owner October 2, 2023 09:17
@carlsberg-security
Copy link

carlsberg-security bot commented Oct 2, 2023 •
edited
Loading

🤖 Auditor

No open issues found, great job! 👍

@SergioVanacloigCarlsberg SergioVanacloigCarlsberg changed the title feat(segmentedcontrol): [DSM-800] add tests feat(segmented-control): [DSM-800] add tests Oct 3, 2023
@aws-amplify-eu-west-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-792.d3acoh2jwy8aw9.amplifyapp.com

@SergioVanacloigCarlsberg SergioVanacloigCarlsberg merged commit 09ee6fc into main Oct 6, 2023
7 checks passed
@SergioVanacloigCarlsberg SergioVanacloigCarlsberg deleted the feat/DSM-800_add-segmentedcontrol-tests branch October 6, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioVanacloigCarlsberg SergioVanacloigCarlsberg SergioVanacloigCarlsberg approved these changes

@samuelsilvadev samuelsilvadev samuelsilvadev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpcav21 @samuelsilvadev @SergioVanacloigCarlsberg