Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(link): remove properties from DOM when using as prop #793

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

samuelsilvadev
Copy link
Contributor

What

  • Made styling props transient so that they are not injected on the DOM. Previously this is what was happening:
image

and was causing warnings in runtime, like this one:

image

  • Updated render utility for tests to have MaltyThemeProvider on top of every test so that we can stop passing the theme prop from the component to the styles

Code Quality Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • I have updated storybook (if appropriate)

Jira Card

Not Applicable

@carlsberg-security
Copy link

carlsberg-security bot commented Oct 2, 2023

🤖 Auditor

No open issues found, great job! 👍

@carlsberg-security
Copy link

🤖 Auditor

⚠️ Warnings

  • Pull Requests should have at least 1 assignee

2 similar comments
@carlsberg-security
Copy link

🤖 Auditor

⚠️ Warnings

  • Pull Requests should have at least 1 assignee

@carlsberg-security
Copy link

🤖 Auditor

⚠️ Warnings

  • Pull Requests should have at least 1 assignee

@aws-amplify-eu-west-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-793.d3acoh2jwy8aw9.amplifyapp.com

nataliaprikhoda
nataliaprikhoda previously approved these changes Oct 3, 2023
@SergioVanacloigCarlsberg SergioVanacloigCarlsberg merged commit 9aeae97 into main Oct 6, 2023
10 of 12 checks passed
@SergioVanacloigCarlsberg SergioVanacloigCarlsberg deleted the fix/link-remove-properties-from-dom branch October 6, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants