-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(link): remove properties from DOM when using as
prop
#793
Merged
SergioVanacloigCarlsberg
merged 4 commits into
main
from
fix/link-remove-properties-from-dom
Oct 6, 2023
Merged
fix(link): remove properties from DOM when using as
prop
#793
SergioVanacloigCarlsberg
merged 4 commits into
main
from
fix/link-remove-properties-from-dom
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 AuditorNo open issues found, great job! 👍 |
🤖 Auditor
|
2 similar comments
🤖 Auditor
|
🤖 Auditor
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
nataliaprikhoda
previously approved these changes
Oct 3, 2023
SergioVanacloigCarlsberg
approved these changes
Oct 4, 2023
nataliaprikhoda
approved these changes
Oct 4, 2023
SergioVanacloigCarlsberg
deleted the
fix/link-remove-properties-from-dom
branch
October 6, 2023 11:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
and was causing warnings in runtime, like this one:
render
utility for tests to haveMaltyThemeProvider
on top of every test so that we can stop passing thetheme
prop from the component to the stylesCode Quality Checklist
Jira Card
Not Applicable