Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): add postcss to resolutions #801

Merged
merged 2 commits into from
Oct 6, 2023
Merged

chore(deps): add postcss to resolutions #801

merged 2 commits into from
Oct 6, 2023

Conversation

SergioVanacloigCarlsberg
Copy link
Contributor

What

Code Quality Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • I have updated storybook (if appropriate)

Jira Card

Not Applicable

@SergioVanacloigCarlsberg SergioVanacloigCarlsberg requested a review from a team as a code owner October 4, 2023 16:09
@carlsberg-security
Copy link

carlsberg-security bot commented Oct 4, 2023 •
edited
Loading

🤖 Auditor

No open issues found, great job! 👍

@SergioVanacloigCarlsberg SergioVanacloigCarlsberg mentioned this pull request Oct 4, 2023
Closed
@aws-amplify-eu-west-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-801.d3acoh2jwy8aw9.amplifyapp.com

samuelsilvadev
samuelsilvadev suggested changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@samuelsilvadev samuelsilvadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this generate a new yarn.lock?

@SergioVanacloigCarlsberg
Copy link
Contributor Author

should this generate a new yarn.lock?

Indeed!

@SergioVanacloigCarlsberg SergioVanacloigCarlsberg merged commit da52905 into main Oct 6, 2023
5 of 8 checks passed
@SergioVanacloigCarlsberg SergioVanacloigCarlsberg deleted the fix/postcss-security-vulnerability branch October 6, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelsilvadev samuelsilvadev Awaiting requested review from samuelsilvadev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioVanacloigCarlsberg @samuelsilvadev @sergiovanacloig