Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pill): [DSM-831] add disable state #815

Merged
merged 4 commits into from
Oct 18, 2023
Merged

feat(pill): [DSM-831] add disable state #815

merged 4 commits into from
Oct 18, 2023

Conversation

acpcor
Copy link
Collaborator

@acpcor acpcor commented Oct 18, 2023

What

  • Include the disable state on the Pill component
  • Rename prop name color to type and the name of the associated interface to make them more self-explained in the context
  • Change pill story file and the files of the dependent components (Product Card and Banner) to be compliant with the new storybook version

Code Quality Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • I have updated storybook (if appropriate)

Jira Card

DSM-831

@acpcor acpcor requested a review from a team as a code owner October 18, 2023 10:03
@carlsberg-security
Copy link

carlsberg-security bot commented Oct 18, 2023 •
edited
Loading

🤖 Auditor

No open issues found, great job! 👍

@carlsberg-security
Copy link

🤖 Auditor

⚠️ Warnings

  • Pull Requests should have at least 1 assignee

@aws-amplify-eu-west-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-815.d3acoh2jwy8aw9.amplifyapp.com

@samuelsilvadev
Copy link
Contributor

since this PR will create a breaking change for the consumers, we should also bump the deps to the next minor

@acpcor
Copy link
Collaborator Author

acpcor commented Oct 18, 2023 •
edited
Loading

since this PR will create a breaking change for the consumers, we should also bump the deps to the next minor

Yes, Sérgio will handle the bump version after the PR is ready to merge (after the approvals) since I have the problem with the memory.

samuelsilvadev
samuelsilvadev previously approved these changes Oct 18, 2023
View reviewed changes
@SergioVanacloigCarlsberg SergioVanacloigCarlsberg dismissed stale reviews from samuelsilvadev and themself via d10f0ad October 18, 2023 15:01
@acpcor acpcor merged commit 8421ba4 into main Oct 18, 2023
11 checks passed
@acpcor acpcor deleted the feat/DSM-831_add-disable-state-to-pill-component branch October 18, 2023 16:30
DiogoMMarques pushed a commit that referenced this pull request Oct 18, 2023
Merge branch 'main' into MS-185-Table-Select
49b30e5 
* main:
  release: Bit GitHub Action (automated) [skip ci]
  feat(pill): [DSM-831] add disable state (#815)
  release: Bit GitHub Action (automated) [skip ci]
  feat(image): [DSM-836] add tests (#808)
  release: Bit GitHub Action (automated) [skip ci]
  fix(productCard): [DSM-844] set the height and width of the loyal badge (#809)
  release: Bit GitHub Action (automated) [skip ci]
  feat(text): [DSM-835] add tests (#807)
  release: Bit GitHub Action (automated) [skip ci]
  feat(input): add quantity variant (#800)
  release: Bit GitHub Action (automated) [skip ci]
  feat(headline): [DSM-834] add tests (#802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioVanacloigCarlsberg SergioVanacloigCarlsberg SergioVanacloigCarlsberg approved these changes

@samuelsilvadev samuelsilvadev samuelsilvadev approved these changes

Assignees

@acpcor acpcor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acpcor @samuelsilvadev @SergioVanacloigCarlsberg @sergiovanacloig