Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(padded-container): adjust tests assertions #817

Merged
merged 2 commits into from
Oct 20, 2023
Merged

test(padded-container): adjust tests assertions #817

merged 2 commits into from
Oct 20, 2023

Conversation

SergioVanacloigCarlsberg
Copy link
Contributor

What

Just checking the tests as .toBeVisible() instead of .not.toBeNull()

Code Quality Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)
  • I have updated storybook (if appropriate)

Jira Card

Not Applicable

@SergioVanacloigCarlsberg SergioVanacloigCarlsberg requested a review from a team as a code owner October 19, 2023 09:22
@carlsberg-security
Copy link

carlsberg-security bot commented Oct 19, 2023 •
edited
Loading

🤖 Auditor

No open issues found, great job! 👍

@carlsberg-security
Copy link

🤖 Auditor

⚠️ Warnings

  • Pull Requests should have at least 1 assignee

@aws-amplify-eu-west-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-817.d3acoh2jwy8aw9.amplifyapp.com

@samuelsilvadev
Copy link
Contributor

since this PR only touches the test files, we could name the PR title with the test type

test(padded-container): adjust tests assertions

@SergioVanacloigCarlsberg SergioVanacloigCarlsberg changed the title fix(padded-container): tests test(padded-container): adjust tests assertions Oct 19, 2023
@SergioVanacloigCarlsberg SergioVanacloigCarlsberg requested a review from a team October 19, 2023 14:44
@SergioVanacloigCarlsberg SergioVanacloigCarlsberg merged commit f3de473 into main Oct 20, 2023
9 of 11 checks passed
@SergioVanacloigCarlsberg SergioVanacloigCarlsberg deleted the fix/padded-container-tests branch October 20, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acpcor acpcor acpcor approved these changes

@samuelsilvadev samuelsilvadev samuelsilvadev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SergioVanacloigCarlsberg @samuelsilvadev @acpcor @sergiovanacloig