Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved voipms:// phone number parsing #1230

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented Oct 27, 2024

Description:

Related issue (if applicable): #1201

Improved phone number parsing while investigating my own error message I was getting which was incredibly vague:

  • 'status: sms_failed', 'message: The SMS message was not sent'

My support ticket got answered with the response:

This type of error usually happens when a DID hasn't been enabled for SMS messages.
You can enable your DID to send and receive SMS Messages by editing your number and select the following:


Enable SMS/MMS ($0.0075/SMS, and $0.02/MMS)

After doing this, I was able to send notifications:

Screenshot from 2024-10-27 09-44-48

This PR just improves a bit on the phone number parsing (making it slightly less restrictive); otherwise there is no core changes from previous version.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1201-voipms-bullet-proofing

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "voipms://credentials/source_no/to_no"

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (78f16ad) to head (dbb0841).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1230   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files         147      147           
  Lines       20554    20555    +1     
  Branches     3663     3662    -1     
=======================================
+ Hits        20424    20425    +1     
  Misses        121      121           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 1065c02 into master Oct 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant