Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bark - add critical level alert plus ?volume= argument #1239

Merged
merged 3 commits into from
Nov 30, 2024

Conversation

pb8DvwQkfRR
Copy link
Contributor

@pb8DvwQkfRR pb8DvwQkfRR commented Nov 16, 2024

Description:

Critical Alert will ignore silent and Do Not Disturb modes.
Volume range: 0-10.

Finb/Bark@f059fde

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/pb8DvwQkfRR/apprise.git@bark-critical

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  bark://api.day.app/<device_key>/?level=critical&volume=1

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.37%. Comparing base (f37dfbf) to head (1ce1981).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1239    +/-   ##
========================================
  Coverage   99.36%   99.37%            
========================================
  Files         147      148     +1     
  Lines       20555    20660   +105     
  Branches     3663     3680    +17     
========================================
+ Hits        20425    20530   +105     
  Misses        121      121            
  Partials        9        9            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc changed the title Bark add critical level alart Bark - add critical level alert plus ?volume= argument Nov 21, 2024
@caronc
Copy link
Owner

caronc commented Nov 29, 2024

Hi, is this ready to go?

@caronc caronc merged commit e9020e6 into caronc:master Nov 30, 2024
13 checks passed
@caronc
Copy link
Owner

caronc commented Nov 30, 2024

Merged

@pb8DvwQkfRR pb8DvwQkfRR deleted the bark-critical branch December 1, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants