-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plivo Support #143
Plivo Support #143
Conversation
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
======================================
Coverage 100% 100%
======================================
Files 57 58 +1
Lines 6653 6760 +107
Branches 1052 1065 +13
======================================
+ Hits 6653 6760 +107
Continue to review full report at Codecov.
|
dd097b6
to
c6cd9b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 71 72 +1
Lines 8323 8419 +96
Branches 1333 1346 +13
=====================================
+ Hits 8323 8419 +96
Continue to review full report at Codecov.
|
c6cd9b5
to
bbd60ee
Compare
4926a03
to
93efa2d
Compare
Maybe if Plivo support was easier to implement, they'de get more customers 👯 :) |
Maybe this issue can be revisited? Ideally, we may find someone from @plivo who likes Apprise to gain corresponding support and who would endorse this in a positive way. It would be so sweet. |
@amotl sure we will check and get back to you soon. |
bbd60ee
to
5711d1b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
========================================
Coverage 99.35% 99.35%
========================================
Files 147 148 +1
Lines 20326 20438 +112
Branches 3979 3997 +18
========================================
+ Hits 20195 20307 +112
Misses 121 121
Partials 10 10 ☔ View full report in Codecov by Sentry. |
Rebased code with master since this branch was really outdated (and with merge conflicts). |
From my account, so one data point: |
@tombii would love it if you could give it another shot! 🙂 |
eb3e162
to
734992a
Compare
New Service Completion Status
keywords
section of thesetup()
declaration%global common_description
Checklist
flake8
)Syntax
plivo://{auth_id}@{token}/{from_phoneno}
plivo://{auth_id}@{token}/{from_phoneno}/{to_phoneno}
plivo://{auth_id}@{token}/{from_phoneno}/{to_phone_no}/{to_phone_no2}/{to_phone_noN}/
Testing
Anyone can help test this source code as follows: