Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete if original_filename as explained in https://github.com/carr… #2711

Merged

Conversation

rajyan
Copy link
Contributor

@rajyan rajyan commented Oct 30, 2023

…ierwaveuploader/carrierwave/blob/master/README.md#changing-the-filename

related to #2708

@rajyan
Copy link
Contributor Author

rajyan commented Oct 30, 2023

The failing test is unrelated to this change.

@rajyan rajyan force-pushed the original-filename-cleanup branch from fb15e8c to 5c8dc98 Compare October 30, 2023 02:38
@rajyan
Copy link
Contributor Author

rajyan commented Oct 30, 2023

Amended and force pushed to rerun the test.

@mshibuya mshibuya merged commit a4ccfe7 into carrierwaveuploader:master Nov 23, 2023
12 checks passed
@mshibuya
Copy link
Member

It's my bad that I left it. Thanks!

@rajyan rajyan deleted the original-filename-cleanup branch November 30, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants