Backport security fixes for 1.x-stable #2752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a backport from carrierwaveuploader@25b1c80 to resolve security vulnerability on 1.3.x branch. Please note that we cannot use exactly the same fix as in the upstream, as 1.3 does not use Marcel.
|
@mshibuya Does the CI pipline work for 1.x-stable? I see random failures there not related to the changes. Please let me know what do you think about the PR anyway. |
|
Yeah it'll take a real effort to make it functional again. I want to avoid the maintenance work if possible... What's the blocker for 3.0 upgrade? |
|
Thanks for the reply. In our case it is just matter of huge codebase and a lot of monkey patches. Nothing that we cannot adjust to 3.x but it will take more time. We will do it anyway in long term, but we thought of having simple and quick alternative short-term solution. If the backport for 1.x is indeed not quick, we will focus on the upgrade to 3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two security vulnerabilities (GHSA-vfmv-jfc5-pjjw and GHSA-gxhx-g4fq-49hj) which were resolved for 2.x and 3.x versions. They have not been addressed in 1.x branch.
I'm aware that using 1.x should not happening anymore, but in our case migration to 3.0 is a painful way which will take time. This backport would allow us to resolve the security vulnerabilities from our systems.