Do not store the WidgetTag + base impl of visitIds
#2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing the WidgetTag is a waste of space. We rarely use it, and even then it's only an int so we can just codegen returning it directly. Do not generate implementations of visitIds for nodes with no children. Have the base class invoke the lambda with the current node ID by default. Only nodes for widigets with children will override and do codegen.
|
Working on #2145 and pulling some prerequisites out |
JakeWharton
force-pushed
the
jw.tweaks.2024-09-23
branch
from
59aa2d5 to
abe19bc
Compare
swankjesse
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing the
WidgetTagis a waste of space. We rarely use it, and even then it's only anintso we can just codegen returning it directly.Do not generate implementations of
visitIdsfor nodes with no children. Have the base class invoke the lambda with the current node ID by default. Only nodes for widgets with children will override and do codegen.CHANGELOG.md's "Unreleased" section has been updated, if applicable.