Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set SESSION->saml2idp during unsolicited logins #759

Merged
merged 1 commit into from
Jun 18, 2024
Merged

set SESSION->saml2idp during unsolicited logins #759

merged 1 commit into from
Jun 18, 2024

Conversation

skodak
Copy link
Contributor

@skodak skodak commented May 3, 2023

This makes the IdP known in saml_login_complete()
and tenant callback.

@skodak
Copy link
Contributor Author

skodak commented May 3, 2023

I suppose this might affect Moodle for Workplace too because the callback for tenant support with $SESSION->saml2idp originated there

@brendanheywood
Copy link
Contributor

thanks @skodak - @kabalin are you able to review this in the context of workplace?

@kabalin
Copy link
Collaborator

kabalin commented May 15, 2023 •
edited
Loading

thanks @skodak - @kabalin are you able to review this in the context of workplace?

This change does not affect Workplace (tested it thoroughly). Cleared to land :)

@kabalin kabalin self-requested a review May 15, 2023 16:43
@skodak
Copy link
Contributor Author

skodak commented Jun 12, 2024

any news?

@danmarsden
Copy link
Member

looks like we forgot about this one - happy to merge, but someone needs to update the patch for the new version of simplesamlphp - I think the change needs to go here now instead:
https://github.com/catalyst/moodle-auth_saml2/blob/MOODLE_39_STABLE/.extlib/simplesamlphp/modules/saml/src/Auth/Source/SP.php#L1136

@skodak
set SESSION->saml2idp during unsolicited logins
9fedfa3 
This makes the IdP known in saml_login_complete()
and tenant callback.
@skodak
Copy link
Contributor Author

skodak commented Jun 13, 2024

patch updated

@danmarsden danmarsden merged commit 974796e into catalyst:MOODLE_39_STABLE Jun 18, 2024
13 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabalin kabalin kabalin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skodak @brendanheywood @kabalin @danmarsden