Update post.twig to point to publicly available post files #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove deprecated post.php
|
This is to maintain 68c62d8 |
|
do we need to delete the php file there? - or just update the post.twig file to make this work? - or does the presence of the php file cause issues? (we try to minimise lib changes to the neccessary ones to make it easier to maintain conflicts.) |
|
@danmarsden Deleting the file would be removing a customisation, it is a leftover from the v2 library update, SimpleSAMLphp removed this file in v2 and when the library was updated here in auth_saml2 the post.php file wasn't deleted |
alexmorrisnz
pushed a commit
that referenced
this pull request
Feb 1, 2024
And remove deprecated post.php Co-authored-by: Noemie Ariste <[email protected]>
jay-oswald
pushed a commit
that referenced
this pull request
Nov 20, 2024
And remove deprecated post.php Co-authored-by: Noemie Ariste <[email protected]>
jay-oswald
pushed a commit
that referenced
this pull request
Nov 28, 2024
And remove deprecated post.php Co-authored-by: Noemie Ariste <[email protected]>
gbarat87
pushed a commit
that referenced
this pull request
Dec 11, 2024
And remove deprecated post.php Co-authored-by: Noemie Ariste <[email protected]>
gbarat87
pushed a commit
that referenced
this pull request
Dec 13, 2024
And remove deprecated post.php Co-authored-by: Noemie Ariste <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures auth_catadmin users get automatically redirected to the Moodle site they are login in. Without it, they get a blank page with a submit button.
I going to test and create a MR for the T13 branch as well.
This commit also removes the deprecated post.php file.