Support for Moodle 404+ #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove deprecated post.php Co-authored-by: Noemie Ariste <[email protected]>
And remove deprecated post.php Co-authored-by: Noemie Ariste <[email protected]>
This makes the IdP known in saml_login_complete() and tenant callback.
tuanngocnguyen
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Looks good to me
Confirm that Catalyst changes have been brought forward: https://github.com/catalyst/moodle-auth_saml2/commits/MOODLE_39_STABLE/.extlib/simplesamlphp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped Simple SAML php to v2.3.3
Cherry-picked our customisations
Cleaned up CI tasks
Passing tests on local, passing 405 branches on GH, 404 branches have the known connection error still