Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #855: add namespace to test classes #856

Merged
merged 2 commits into from
Dec 16, 2024
Merged

issue #855: add namespace to test classes #856

merged 2 commits into from
Dec 16, 2024

Conversation

dmitriim
Copy link
Member

fixes #855

@dmitriim
Copy link
Member Author

Seems like behats for 4.4 failed before this change.

@dmitriim dmitriim changed the title issue #855: add namespace to generator_test class issue #855: add namespace to test classes Dec 16, 2024
jay-oswald
jay-oswald approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@jay-oswald jay-oswald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just adding a namespace, all tests are updated. No verison bump, and no release is needed since just change to the tests

@jay-oswald jay-oswald merged commit 20ffe29 into MOODLE_404_STABLE Dec 16, 2024
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay-oswald jay-oswald jay-oswald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class generator_test should be namespaced
2 participants
@dmitriim @jay-oswald