Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkedQL: Schema Format Correction & Missing Steps #902

Merged
merged 14 commits into from
Dec 30, 2019

Conversation

iddan
Copy link
Collaborator

@iddan iddan commented Dec 20, 2019

Extract correction for the schema file format from #897.

  • The schema file holds an array of documents. But for JSON-LD to parse it correctly the array should be a value to @graph property.
  • Correct schema file @context format
  • Register missing steps
  • Parse LinkedQL document properties correctly
  • Return JSON-LD documents instead of JSON documents
  • Parse ProperyPath correctly

This change is Reviewable

@iddan iddan added the bug label Dec 20, 2019
@iddan iddan added this to the v0.8.0 milestone Dec 20, 2019
@iddan iddan requested a review from dennwc December 20, 2019 16:23
@iddan iddan self-assigned this Dec 20, 2019
@iddan iddan mentioned this pull request Dec 20, 2019
2 tasks
@iddan iddan changed the title LinkedQL: Schema Format Correction LinkedQL: Schema Format Correction & Missing Steps Dec 20, 2019
@iddan iddan mentioned this pull request Dec 27, 2019
5 tasks
@dennwc dennwc force-pushed the linkedql/schema-format-correction branch from b218f5c to ce8b18b Compare December 30, 2019 09:46
@dennwc dennwc force-pushed the linkedql/schema-format-correction branch from ce8b18b to 66c5c58 Compare December 30, 2019 10:02
Copy link
Member

@dennwc dennwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 11 files at r1, 3 of 3 files at r3, 4 of 4 files at r4, 1 of 1 files at r5.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dennwc dennwc merged commit 3cc8244 into master Dec 30, 2019
@dennwc dennwc deleted the linkedql/schema-format-correction branch December 30, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants