cleanup (thanks for the review); bump version

README.md

@@ -1,6 +1,6 @@
 # gsjackctl – GNOME Shell JACK Control
 
-_This GNOME Shell-extension is a work in progress._
+_I'm not actively working on this extension anymore since I personally switched to PipeWire, however if there are people using it I'll try to keep it updated for new gnome-shell versions and will accept bugfix PRs!_
 
 ## About
 **gsjackctl** is a simple GNOME extension to control the JACK audio system. It works only with jack2 using jackdbus.
@@ -14,3 +14,5 @@ Dev install:
 ```
 git clone https://github.com/cbix/gsjackctl ~/.local/share/gnome-shell/extensions/[email protected]
 ```
+
+Or get the latest release by downloading the `[email protected]` asset from the [latest release](https://github.com/cbix/gsjackctl/releases/latest).

extension.js

@@ -7,7 +7,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
-const Local = imports.ui.main.extensionManager.lookup('[email protected]');
+const Local = imports.misc.extensionUtils.getCurrentExtension();
 
 const {Extension} = Local.imports.gsjackctl.extension;
 

gsjackctl/a2jControl.js

@@ -7,7 +7,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
-const Local = imports.ui.main.extensionManager.lookup('[email protected]');
+const Local = imports.misc.extensionUtils.getCurrentExtension();
 
 const {Clutter, GObject} = imports.gi;
 const PopupMenu = imports.ui.popupMenu;

gsjackctl/control.js

@@ -7,7 +7,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
-const Local = imports.ui.main.extensionManager.lookup('[email protected]');
+const Local = imports.misc.extensionUtils.getCurrentExtension();
 
 const {Clutter, GObject} = imports.gi;
 const PopupMenu = imports.ui.popupMenu;

gsjackctl/extension.js

@@ -7,7 +7,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
-const Local = imports.ui.main.extensionManager.lookup('[email protected]');
+const Local = imports.misc.extensionUtils.getCurrentExtension();
 
 const {GLib, GObject} = imports.gi;
 const Main = imports.ui.main;
@@ -26,6 +26,7 @@ var Extension = class Extension {
         this._status = null;
         this._buffersize = 256;
         this._backgroundRunning = false;
+        this._backgroundSource = null;
 
         // TODO make this configurable
         this._a2jAutostart = true;
@@ -134,6 +135,13 @@ var Extension = class Extension {
     disable() {
         this._indicator.destroy();
         this._indicator = null;
+        this._jackctl = null;
+        this._a2jControl = null;
+        this._status = null;
+        this._control = null;
+        if (this._backgroundSource && this._backgroundRunning)
+            GLib.Source.remove(this._backgroundSource);
+
     }
 
     updateStatus() {
@@ -171,7 +179,7 @@ var Extension = class Extension {
     startBackground(interval = 2000) {
         if (this.updateStatus() && !this._backgroundRunning) {
             this._backgroundRunning = true;
-            GLib.timeout_add(GLib.PRIORITY_DEFAULT, interval, () => {
+            this._backgroundSource = GLib.timeout_add(GLib.PRIORITY_DEFAULT, interval, () => {
                 this._backgroundRunning = this.updateStatus();
                 return this._backgroundRunning;
             });

gsjackctl/indicator.js

@@ -7,7 +7,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
-const Local = imports.ui.main.extensionManager.lookup('[email protected]');
+const Local = imports.misc.extensionUtils.getCurrentExtension();
 
 const {Clutter, GObject, St, Gio, GLib} = imports.gi;
 const PanelMenu = imports.ui.panelMenu;

gsjackctl/status.js

@@ -7,7 +7,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
-const Local = imports.ui.main.extensionManager.lookup('[email protected]');
+const Local = imports.misc.extensionUtils.getCurrentExtension();
 
 const {Clutter, GObject, St} = imports.gi;
 const PopupMenu = imports.ui.popupMenu;

metadata.json

@@ -9,5 +9,5 @@
   ],
   "url": "https://github.com/cbix/gsjackctl",
   "uuid": "[email protected]",
-  "version": 1
+  "version": 2
 }