Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some type checker warnings #229

Merged
merged 11 commits into from
Jul 22, 2024
Merged

Fix some type checker warnings #229

merged 11 commits into from
Jul 22, 2024

Conversation

cbrnr
Copy link
Owner

@cbrnr cbrnr commented Jul 19, 2024

WIP

@cbrnr
Copy link
Owner Author

cbrnr commented Jul 19, 2024

@hofaflo would you care to take a look, specifically if you are OK with the config change?

@cbrnr
Copy link
Owner Author

cbrnr commented Jul 19, 2024

I think get_config_key() should be renamed to get_config_value() (thanks @hoechenberger!). I'll do that.

@hofaflo
Copy link
Collaborator

hofaflo commented Jul 22, 2024

Yes, I think this is a very good idea, thanks for fixing that and the typing chaos! 😅

@cbrnr cbrnr merged commit db52b67 into main Jul 22, 2024
5 checks passed
@cbrnr cbrnr deleted the type-annotations branch July 22, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbrnr @hofaflo