-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support storing nsrr_token in config or environment variable #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I'd prefer the environment variable to be NSRR_TOKEN
(all caps), since this is more customary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you've addressed these comments, please update the corresponding section in the docs and add an entry to CHANGELOG.md
.
Co-authored-by: Clemens Brunner <[email protected]>
The config system also needs to be updated in order to recognize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few final comments and this is ready!
Co-authored-by: Clemens Brunner <[email protected]>
Co-authored-by: Clemens Brunner <[email protected]>
Co-authored-by: Clemens Brunner <[email protected]>
Co-authored-by: Clemens Brunner <[email protected]>
Thanks a lot @simon-p-2000 🎉! |
Added support for storing the nsrr_token in an environment variable or the config file of sleepecg. Since the nsrr_token can be set in multiple ways, the hierarchy for which nsrr_token is used is set as such:
Currently, sleepecg provides no functionality to set the nsrr_token as an environment variable or in the config file. Instead, these actions have to be performed by hand.
In addtion, the test_nsrr.py file was added introducing four test cases. Three cases cover the setting of the nsrr_token via methods 1-3 while the fourth test case covers an unset nsrr_token.