Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism to dynamically control visibility of fields and types #68

Closed
wants to merge 1 commit into from

Conversation

ccbrown
Copy link
Owner

@ccbrown ccbrown commented Mar 5, 2024

What it Does

This enables users to implement feature flagging as described in https://github.com/graphql/graphql-wg/blob/main/rfcs/OptInFeatures.md by defining functions on field and type definitions which control their visibility.

Steps to Test

go test -v ./...

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 79.36%. Comparing base (c289cff) to head (57d1c2d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   79.61%   79.36%   -0.25%     
==========================================
  Files          62       62              
  Lines        5042     5060      +18     
==========================================
+ Hits         4014     4016       +2     
- Misses        681      697      +16     
  Partials      347      347              
Files Coverage Δ
graphql/schema/field_definition.go 36.36% <ø> (ø)
graphql/schema/schema.go 77.65% <ø> (ø)
graphql/schema/enum_type.go 64.28% <0.00%> (-7.72%) ⬇️
graphql/schema/input_object_type.go 73.77% <0.00%> (-3.82%) ⬇️
graphql/schema/interface_type.go 33.33% <0.00%> (-8.34%) ⬇️
graphql/schema/object_type.go 46.51% <0.00%> (-3.49%) ⬇️
graphql/schema/scalar_type.go 82.35% <0.00%> (-17.65%) ⬇️
graphql/schema/union_type.go 38.88% <0.00%> (-7.78%) ⬇️

... and 1 file with indirect coverage changes

@ccbrown
Copy link
Owner Author

ccbrown commented Mar 9, 2024

Abandoning in favor of a mechanism that can be better validated before execution time.

@ccbrown ccbrown closed this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant