Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 make sure to define Py_GIL_DISABLED on Windows for Python 3.13t #452

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

burgholzer
Copy link
Member

Description

As pointed out in pypa/cibuildwheel#1975 (comment) free-threading (Python 3.13t) builds on Windows need to have Py_GIL_DISABLED set in order to properly work.
This PR ensures that the corresponding setting is always set.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Sep 5, 2024
@burgholzer burgholzer added python Anything related to Python code fix Anything related to bugfixes labels Sep 5, 2024
@burgholzer burgholzer enabled auto-merge (squash) September 5, 2024 12:15
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.2%. Comparing base (a0a61e2) to head (adbfeed).
Report is 83 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #452     +/-   ##
=======================================
- Coverage   95.3%   95.2%   -0.1%     
=======================================
  Files         40      40             
  Lines       1837    1837             
  Branches     224     224             
=======================================
- Hits        1751    1750      -1     
- Misses        86      87      +1     
Flag Coverage Δ
cpp 95.6% <ø> (-0.1%) ⬇️
python 93.7% <ø> (ø)

see 1 file with indirect coverage changes

@burgholzer burgholzer merged commit fd93799 into main Sep 5, 2024
34 checks passed
@burgholzer burgholzer deleted the free-threaded-windows branch September 5, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Anything related to bugfixes python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant