Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 make sure to define Py_GIL_DISABLED on Windows for Python 3.13t #513

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

burgholzer
Copy link
Member

Description

As pointed out in pypa/cibuildwheel#1975 (comment) free-threading (Python 3.13t) builds on Windows need to have Py_GIL_DISABLED set in order to properly work.
This PR ensures that the corresponding setting is always set.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Sep 5, 2024
@burgholzer burgholzer added python Anything related to Python code fix Anything related to bugfixes labels Sep 5, 2024
@burgholzer burgholzer enabled auto-merge (squash) September 5, 2024 12:18
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.4%. Comparing base (752cec2) to head (f9457b7).
Report is 190 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #513     +/-   ##
=======================================
- Coverage   90.4%   90.4%   -0.1%     
=======================================
  Files         86      86             
  Lines      10024   10025      +1     
  Branches    1711    1711             
=======================================
- Hits        9070    9067      -3     
- Misses       954     958      +4     
Flag Coverage Δ
cpp 90.1% <ø> (-0.1%) ⬇️
python 96.0% <ø> (ø)

see 2 files with indirect coverage changes

@burgholzer burgholzer merged commit cf93f65 into main Sep 5, 2024
34 checks passed
@burgholzer burgholzer deleted the free-threading-windows branch September 5, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Anything related to bugfixes python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant