Aaronjeline/logmore #137
Merged
Aaronjeline/logmore #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaobo-he-aws
approved these changes
Oct 25, 2023
cdisselkoen
reviewed
Oct 27, 2023
Comment on lines
-35
to
53
| #[derive(Debug, Clone)] | ||
| #[derive(Debug, Clone, Serialize)] | ||
| struct FuzzTargetInput { | ||
| /// generated schema | ||
| #[serde(skip)] | ||
| pub schema: Schema, | ||
| /// generated entity slice | ||
| #[serde(skip)] | ||
| pub entities: Entities, | ||
| /// Should we pre-evaluate entity attributes | ||
| #[serde(skip)] | ||
| pub should_cache_entities: bool, | ||
| /// generated policy | ||
| pub policy: ABACPolicy, | ||
| /// the requests to try for this hierarchy and policy. We try 8 requests per | ||
| /// policy/hierarchy | ||
| #[serde(skip)] | ||
| pub requests: [ABACRequest; 8], | ||
| } |
There was a problem hiding this comment.
I would expect serialize to include most of these fields. Can we just call serialize on .policy if this is what we want?
There was a problem hiding this comment.
Nah, because I need it to be the FuzzTargetInput so I can log all of them via the macro easily.
|
|
||
| ## Logging | ||
|
|
||
| If the fuzz targets are compiled with the `log` features, then they will log their entire corpus to the file pointed at in the `LOGFILE` environment variable. |
There was a problem hiding this comment.
idk if "corpus" is the right word here -- does "corpus" imply some amount of minimization?
There was a problem hiding this comment.
I don't think so, "corpus minimization" is a second step one applies to the corpus
andrewmwells-amazon
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Provides the ability to log the corpus generated.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.