Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to generate is operator #145

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Conversation

john-h-kastner-aws
Copy link
Contributor

Update for cedar-policy/cedar#396. Generators may generate is based on an enable_is flag. This is disabled for differential testing because is is not modeled in Dafny, but it is enabled for property tests.

Generators may generate `is` based on an `enable_is` flag. This is
disabled for differential testing because `is` is not modeled in dafny,
but it is enabled for property tests.
Copy link
Contributor

@khieta khieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR only updates expression generation. I think you want to update the generation of head constraints as well (look for instances of PrincipalOrResourceConstraint in the cedar-policy-generators crate)

cedar-drt/fuzz/fuzz_targets/validation-pbt.rs Outdated Show resolved Hide resolved
cedar-policy-generators/src/expr.rs Outdated Show resolved Hide resolved
@john-h-kastner-aws john-h-kastner-aws merged commit 2f32681 into main Nov 15, 2023
3 checks passed
@khieta khieta mentioned this pull request Nov 16, 2023
@khieta khieta deleted the feature/jkastner/is branch November 16, 2023 17:56
khieta added a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants