Fail DRT build quickly if lean build dir isn't present #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdisselkoen
reviewed
Nov 19, 2024
cedar-drt/build.rs
Outdated
Comment on lines
25
to
28
| if !Path::new("../cedar-lean/.lake/build/lib").exists() { | ||
| panic!("Lean build directory does not exist! Try running `( cd ../cedar-lean && ../cedar-drt/build_lean_lib.sh )`") | ||
| } | ||
| println!("cargo:rustc-link-search=native=../cedar-lean/.lake/build/lib"); |
There was a problem hiding this comment.
The same path is hardcoded twice, should we make it a variable
Not really. That will already require adding a condition build file to not error when |
cdisselkoen
approved these changes
Nov 19, 2024
Signed-off-by: John Kastner <[email protected]>
Signed-off-by: John Kastner <[email protected]>
cdisselkoen
approved these changes
Nov 19, 2024
shaobo-he-aws
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to improve on another papercut in the DRT build process. Add this to remind myself that I need to build the lean library.