isEmpty method
#487
Merged
isEmpty method
#487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <[email protected]>
emina
approved these changes
Dec 6, 2024
|
Strange CI failure, where during the build of the |
|
It's not that the |
Signed-off-by: Craig Disselkoen <[email protected]>
|
Resolved itself on a retry. Weird. |
This reverts commit 76fe903. Signed-off-by: Craig Disselkoen <[email protected]>
cdisselkoen
force-pushed
the
cdisselkoen/isEmpty
branch
from
b7958ef to
39ddc4b
Compare
emina
approved these changes
Dec 6, 2024
john-h-kastner-aws
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
isEmptymethod (introduced by cedar-policy/cedar#1358) to the Lean and DRT. For the DRT, the only change necessary was adjusting policy generators to be capable of generating.isEmpty()expressions. For Lean, the evaluator and typechecker had to be adjusted to handle the new operator.