-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Protobuf for DRT #488
Merged
Merged
Use Protobuf for DRT #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Disselkoen <[email protected]>
cdisselkoen
requested review from
emina,
shaobo-he-aws and
john-h-kastner-aws
December 9, 2024 18:32
Signed-off-by: Craig Disselkoen <[email protected]>
emina
approved these changes
Dec 9, 2024
Signed-off-by: Craig Disselkoen <[email protected]>
Signed-off-by: Craig Disselkoen <[email protected]>
john-h-kastner-aws
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though I can't vouch for the correctness of the FFI code
Closed
3 tasks
Signed-off-by: Craig Disselkoen <[email protected]>
Integration-tests CI failure is due (at least in part) to needing cedar-policy/cedar#1365 |
This was referenced Dec 9, 2024
Closed
john-h-kastner-aws
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isAuthorized
andvalidate
requests from Rust to Lean.Cli
executable to expect Protobuf-encoded inputs forisAuthorized
andvalidate
(still expects JSON for other targets, likevalidateEntities
andvalidateRequest
).Cli
executable, which used hardcoded JSON inputs. Tests for protobuf functionality, with protobuf inputs, were added in Cedar protobuf structures #485 (although they don't test theCli
specifically).