Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Entity Manifest Analysis #1154

Closed

Conversation

oflatt
Copy link
Contributor

@oflatt oflatt commented Aug 28, 2024

Description of changes

This PR extends the entity manifest analysis to support all of Cedar. It does this by defining a new static analysis result WrappedAccessPaths that stores a set of paths possibly wrapped in set or record literals.

PR stack:
#1102
#1105
#1154 (This PR)
#1156
#1171
#1196
#1208

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A breaking change requiring a major version bump to cedar-policy (e.g., changes to the signature of an existing API).
  • A backwards-compatible change requiring a minor version bump to cedar-policy (e.g., addition of a new API).
  • A bug fix or other functionality change requiring a patch to cedar-policy.
  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)
  • A change (breaking or otherwise) that only impacts unreleased or experimental code.

I confirm that this PR (choose one, and delete the other options):

  • Updates the "Unreleased" section of the CHANGELOG with a description of my change (required for major/minor version bumps).
  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.
  • Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)
  • Requires updates, but I do not plan to make them in the near future. (Make sure that your changes are hidden behind a feature flag to mark them as experimental.)
  • I'm not sure how my change impacts cedar-spec. (Post your PR anyways, and we'll discuss in the comments.)

@oflatt oflatt force-pushed the oflatt/full-entity-manifest-analysis branch from c18be9c to c349829 Compare August 28, 2024 18:44
@oflatt oflatt marked this pull request as ready for review August 28, 2024 18:49
@oflatt oflatt force-pushed the oflatt/full-entity-manifest-analysis branch from c349829 to 98c63db Compare August 28, 2024 19:07
@oflatt oflatt force-pushed the oflatt/entity-slicing branch from ea27913 to 1b72442 Compare August 28, 2024 21:35
@oflatt oflatt force-pushed the oflatt/full-entity-manifest-analysis branch 3 times, most recently from d745c09 to 346d24c Compare August 28, 2024 21:41
@oflatt oflatt force-pushed the oflatt/entity-slicing branch from 1b72442 to 484a00c Compare September 3, 2024 18:24
@shaobo-he-aws
Copy link
Contributor

Closed in favor of a single PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants