Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for cedar-spec#219 #639

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Updates for cedar-spec#219 #639

merged 1 commit into from
Feb 13, 2024

Conversation

khieta
Copy link
Contributor

@khieta khieta commented Feb 13, 2024

Description of changes

Updates comments to use "formal model" in places where we previously used "Dafny model". cedar-spec#219 deprecates the Dafny model in favor of a model in Lean.

I'm not sure if the alternate serialization used in cedar-policy-core/src/ast/pattern.rs is still needed now that we've switched Lean, but what we have now works so I'm hesitant to change it.

There is one other place we refer to "Dafny" in the code -- I've made an issue (#638) to follow up on that later.

Issue #, if available

Checklist for requesting a review

The change in this PR is (choose one, and delete the other options):

  • A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

  • Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

  • Does not require updates because my change does not impact the Cedar Dafny model or DRT infrastructure.

Disclaimer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@khieta khieta marked this pull request as ready for review February 13, 2024 18:45
@shaobo-he-aws
Copy link
Contributor

I'm not sure if the alternate serialization used in cedar-policy-core/src/ast/pattern.rs is still needed now that we've switched Lean, but what we have now works so I'm hesitant to change it.

We should keep it unless we change the deserializer in Lean, which I doubt will be an easy task given JSON doesn't have a character type.

@khieta khieta merged commit a4c18c3 into main Feb 13, 2024
11 checks passed
@khieta khieta deleted the khieta/deprecate-dafny branch February 13, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants