Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buyback and add fee split #11234

Merged
merged 47 commits into from
Oct 14, 2024
Merged

Fix buyback and add fee split #11234

merged 47 commits into from
Oct 14, 2024

Conversation

martinvol
Copy link
Contributor

@martinvol martinvol commented Oct 4, 2024 •
edited
Loading

@martinvol martinvol requested a review from a team as a code owner October 4, 2024 14:12
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Oct 4, 2024 •
edited
Loading

Fix buyback and add fee split

Generated at commit: aa923156696eb1fd441d61e3b20786bff5342d49

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
2
0
14
43
62
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@martinvol martinvol changed the title Fix buyback Fix buyback and add fee split Oct 6, 2024
pahor167
pahor167 reviewed Oct 7, 2024
View reviewed changes
packages/protocol/contracts/common/FeeHandler.sol
) internal {
Beneficiary storage beneficiary = otherBeneficiaries[beneficiaryAddress];
require(beneficiary.exists, "Beneficiary not found");
totalFractionOfOtherBeneficiaries = totalFractionOfOtherBeneficiaries.add(newFraction);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be checking whether this is <= 1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok checkTotalBeneficiary is doing that - should we have it <= 1 rather than <1 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have tested the edge case where burningFraction = 0, so would leave it like this.

@martinvol martinvol enabled auto-merge (squash) October 14, 2024 13:09
@martinvol martinvol merged commit ed2c008 into release/core-contracts/12 Oct 14, 2024
42 checks passed
@martinvol martinvol deleted the martinvol/fixFeeHandler branch October 14, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-chrzan m-chrzan m-chrzan left review comments

@pahor167 pahor167 pahor167 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinvol @m-chrzan @pahor167