Cleanup forge remappings #11301
Merged
Cleanup forge remappings #11301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forge remappings were placed in 3 different files, one of which doesn't even appear to be used anywhere. This PR consolidates all of them into
remappings.txtin the protocol package.TODO:
scripts/foundry/deploy_libraries.shcopies necessary files (includingfoundry.toml) to a temporary directory.remappings.txtwas not depended on, but is needed now, so added it there.Tested
forge clean && forge build && forge testworksOther changes
Copy
remappings.txtduring library build process inscripts/foundry/deploy_libraries.sh.Related issues