Miljoeportal #302
Open
Miljoeportal #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…processing a list of file paths.
…s dsk crawled data.
…case of worker termination errors.
This was
linked to
issues
Dec 16, 2024
KennethEnevoldsen
approved these changes
Dec 21, 2024
| To pull data run: | ||
|
|
||
| ```bash | ||
| $ uv run data-processing/scripts/miljoeportal/download.py $PATH_TO_SAVE_RAW_DATA $PATH_TO_SAVE_EXTRACTED_DATA4 |
There was a problem hiding this comment.
Suggested change
| $ uv run data-processing/scripts/miljoeportal/download.py $PATH_TO_SAVE_RAW_DATA $PATH_TO_SAVE_EXTRACTED_DATA4 | |
| $ python data-processing/scripts/miljoeportal/download.py $PATH_TO_SAVE_RAW_DATA $PATH_TO_SAVE_EXTRACTED_DATA4 |
I think we should be consistent throughout (I am perfectly fine with consistently using uv
Comment on lines
+25
to
+27
| Returns: | ||
| bool: If the pull was succesful or not. | ||
| """ |
There was a problem hiding this comment.
Suggested change
| Returns: | |
| bool: If the pull was succesful or not. | |
| """ | |
| Returns: | |
| If the pull was succesful or not. | |
| """ |
There was a problem hiding this comment.
(generally if you already have the type hint I would not add it in docs
Comment on lines
+59
to
+60
| Returns: | ||
| list[str]: _description_ |
There was a problem hiding this comment.
Suggested change
| Returns: | |
| list[str]: _description_ |
|
|
||
| Args: | ||
| file_path (Path): Path to where to save raw files | ||
| id_ (str): Assess |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Danmarks Miljøportal data. #301
Merging this will also close #299 and #298