Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INSTALL: Add telemetry server installation documentation #23

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

yaarith
Copy link
Contributor

@yaarith yaarith commented Mar 14, 2022

Add also the dashboard's JSON files for an easy Grafana installation.

Signed-off-by: Yaarit Hatuka [email protected]

@yaarith yaarith requested a review from dmick March 14, 2022 15:15
Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay otherwise; obviously I'm assuming all the JSON is correct and complete :)

INSTALL.md Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
compress_raw_reports_telemetry.sh Show resolved Hide resolved
compress_raw_reports_telemetry.sh Show resolved Hide resolved
# Ceph Telemetry Installation

## Minimum requirements
- RHEL 8 based OS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how hard a requirement is this? Will, say, CentOS Stream work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently mod_evasive is not available in CentOS Stream, which is a problem

@yaarith
Copy link
Contributor Author

yaarith commented Mar 16, 2022

thanks for the review!
Indeed, JSONs are valid :-)
Pushed fixes, will squash once re-reviewed.

INSTALL.md Outdated
```

## Install PostgreSQL and Grafana
You can install Postgres and Grafana from RPM or as containers. below is how to install as containers
Copy link

@jeffvance jeffvance Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uppercase "B" (below is...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jeffvance, fixed!


path="/opt/telemetry/raw/"

for f in `ls -1 $path | grep -v ".gz"`; do
Copy link

@jeffvance jeffvance Mar 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to be concerned with directories matching the ls|grep? If so then consider using something like for f in $(find . -type f -not -name "*.gz"); do ...
A side benefit is find may not need you to set and restore IFS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. This directory is private to the telemetry server and is always flat with nothing but the raw reports.
Maybe the cleanest would be:
find . -type f -not -name "*.gz" -exec "gzip..."
this way we don't need to iterate at all.

Add also the dashboard's JSON files for an easy Grafana installation.

Signed-off-by: Yaarit Hatuka <[email protected]>
@dmick dmick self-requested a review March 23, 2022 07:23
@dmick dmick merged commit 652ab45 into ceph:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants