-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INSTALL: Add telemetry server installation documentation #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay otherwise; obviously I'm assuming all the JSON is correct and complete :)
# Ceph Telemetry Installation | ||
|
||
## Minimum requirements | ||
- RHEL 8 based OS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how hard a requirement is this? Will, say, CentOS Stream work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently mod_evasive is not available in CentOS Stream, which is a problem
thanks for the review! |
INSTALL.md
Outdated
``` | ||
|
||
## Install PostgreSQL and Grafana | ||
You can install Postgres and Grafana from RPM or as containers. below is how to install as containers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uppercase "B" (below is...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jeffvance, fixed!
|
||
path="/opt/telemetry/raw/" | ||
|
||
for f in `ls -1 $path | grep -v ".gz"`; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need to be concerned with directories matching the ls|grep
? If so then consider using something like for f in $(find . -type f -not -name "*.gz"); do ...
A side benefit is find
may not need you to set and restore IFS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. This directory is private to the telemetry server and is always flat with nothing but the raw reports.
Maybe the cleanest would be:
find . -type f -not -name "*.gz" -exec "gzip..."
this way we don't need to iterate at all.
Add also the dashboard's JSON files for an easy Grafana installation. Signed-off-by: Yaarit Hatuka <[email protected]>
Add also the dashboard's JSON files for an easy Grafana installation.
Signed-off-by: Yaarit Hatuka [email protected]