Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deep-eql bump package to support symbols comparison #1483

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

snewcomer
Copy link
Contributor

@snewcomer snewcomer requested a review from a team as a code owner November 7, 2022 16:23
@keithamus keithamus merged commit 8e780b4 into chaijs:4.x.x Nov 7, 2022
@snewcomer snewcomer deleted the sn/bump-deep-eql-4.x branch November 7, 2022 16:27
@bugwelle
Copy link
Contributor

bugwelle commented Nov 8, 2022

It seems that https://www.chaijs.com/releases/ does not include the latest releases. Could it be added? This change is rather important because it broke our tests (or rather: showed we had issues). :-)

@snewcomer
Copy link
Contributor Author

@bugwelle What exact error are you seeing? Chai.js seems to be published on npm - https://www.npmjs.com/package/chai

kodiakhq bot referenced this pull request in erezrokah/aws-testing-library Nov 14, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [chai](http://chaijs.com) ([source](https://togithub.com/chaijs/chai))
| [`4.3.6` ->
`4.3.7`](https://renovatebot.com/diffs/npm/chai/4.3.6/4.3.7) |
[![age](https://badges.renovateapi.com/packages/npm/chai/4.3.7/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/chai/4.3.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/chai/4.3.7/compatibility-slim/4.3.6)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/chai/4.3.7/confidence-slim/4.3.6)](https://docs.renovatebot.com/merge-confidence/)
|
|
[@types/chai](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/chai)
([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped)) |
[`4.3.3` ->
`4.3.4`](https://renovatebot.com/diffs/npm/@types%2fchai/4.3.3/4.3.4) |
[![age](https://badges.renovateapi.com/packages/npm/@types%2fchai/4.3.4/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/@types%2fchai/4.3.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/@types%2fchai/4.3.4/compatibility-slim/4.3.3)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/@types%2fchai/4.3.4/confidence-slim/4.3.3)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>chaijs/chai</summary>

### [`v4.3.7`](https://togithub.com/chaijs/chai/releases/tag/v4.3.7)

[Compare
Source](https://togithub.com/chaijs/chai/compare/v4.3.6...v4.3.7)

#### What's Changed

- fix: deep-eql bump package to support symbols comparison by
[@&#8203;snewcomer](https://togithub.com/snewcomer) in
[https://github.com/chaijs/chai/pull/1483](https://togithub.com/chaijs/chai/pull/1483)

**Full Changelog**:
chaijs/chai@v4.3.6...v4.3.7

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/erezrokah/aws-testing-library).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yMy4xIiwidXBkYXRlZEluVmVyIjoiMzQuMjMuMSJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@bugwelle
Copy link
Contributor

@snewcomer Sorry for the late reply, I must have marked the notification as read...


The chai release log on https://www.chaijs.com/releases/ does not include 4.3.7. The latest version mentioned there is 4.3.4. That made it hard to debug.

Our tests failed because we only want to compare enumerable properties (using deep equal). With this change, non-enumerable Symbols are now checked as well. In my case, we only had to adapt one assertion. Colleagues, however, will need to adapt way more.

What made this even more bothersome to debug: The default assertion messages we got (using mocha) said something like "{ a: 1 } is no equal to { a: 1}". I had to debug it to see that one of the objects had a Symbol on it.

IMHO, this is a breaking change, which is fine for 5.x, but rather annoying for 4.3.7. In my case, though, my tests are fixed now, so I don't mind it too much.

@keithamus
Copy link
Member

Sorry about the breaking change 😞, it's not ideal.

keithamus added a commit that referenced this pull request Feb 7, 2023
* Fixed a regression that caused SyntaxErrors on IE 11

The changes made in #1334 incorrectly used an arrow function and as this isn't supported on IE 11 it causes a SyntaxError to be thrown when loading chai.

* [email protected]

* export chai.Assertion (#1378)

* [email protected]

* fix: support inspecting bigints (#1321) (#1383)

* 4.3.4

* feat: use chaijs/loupe for inspection (#1401) (#1407)

Fix #1228

* fix: package.json - deprecation warning on exports field (#1400)

* fix package.json exports

* build(deps-dev): bump codecov from 3.1.0 to 3.7.1 (#1446)

Bumps [codecov](https://github.com/codecov/codecov-node) from 3.1.0 to 3.7.1.
- [Release notes](https://github.com/codecov/codecov-node/releases)
- [Changelog](https://github.com/codecov/codecov-node/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-node@v3.1.0...v3.7.1)

---
updated-dependencies:
- dependency-name: codecov
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build chaijs

* 4.3.5

* fix: use loupe@^2.3.1

* build chaijs

* 4.3.6

* fix: deep-eql bump package to support symbols comparison (#1483)

* 4.3.7

* build

* chore: 4.x.x: Fix link to commit logs on GitHub (#1487)

* 4.x.x: Fix link to commit logs on GitHub

As there is no `master` branch, the link returned a 404.

* Update History.md

Co-authored-by: Andre Meyering <[email protected]>

Co-authored-by: Keith Cirkel <[email protected]>

* build(deps): bump socket.io-parser from 4.0.4 to 4.0.5 (#1488)

Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](socketio/socket.io-parser@4.0.4...4.0.5)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* test: fix typo in test.js (#1459)

* docs: specify return type of objDisplay (#1490)

previously it was incorrectly labeled as `objDisplay(obj: object): void` in `@types/chai`.

* feat: rework into ES modules

This moves all of the sources to be ES modules rather than CommonJS.

In order to produce the entrypoints, we use esbuild as a bundler (and as
a transpiler in a way).

Due to the fact that some dependencies are written in CommonJS, we
actually use esbuild to create _two_ bundles: a CommonJS bundle, and an
ES module bundle.

Otherwise, someone importing the raw source would inevitably end up
trying to import a CommonJS module somewhere down the tree, which would
not work in browsers natively.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Lee Newson <[email protected]>
Co-authored-by: Keith Cirkel <[email protected]>
Co-authored-by: rbruckheimer <[email protected]>
Co-authored-by: Mike Frysinger <[email protected]>
Co-authored-by: Pascal Corpet <[email protected]>
Co-authored-by: Mimi <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Scott Newcomer <[email protected]>
Co-authored-by: Andre Meyering <[email protected]>
Co-authored-by: Mavaddat Javid <[email protected]>
Co-authored-by: scarf <[email protected]>
Co-authored-by: James Garbutt <[email protected]>
@simlu
Copy link

simlu commented Jul 24, 2023

Man... a breaking change like this with a minor version increment 😞

Thanks for all the hard work, but this definitely just caused me some headaches. Time to roll back!

Woodpile37 added a commit to Woodpile37/EIPs that referenced this pull request Nov 4, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade chai from
4.3.6 to 4.3.10.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>

- The recommended version is **4 versions** ahead of your current
version.
- The recommended version was released **a month ago**, on 2023-09-28.


<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>chai</b></summary>
    <ul>
      <li>
<b>4.3.10</b> - <a
href="https://snyk.io/redirect/github/chaijs/chai/releases/tag/v4.3.10">2023-09-28</a></br><p>This
release simply bumps all dependencies to their latest non-breaking
versions.</p>
<h2>What's Changed</h2>
<ul>
<li>upgrade all dependencies by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/keithamus/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/keithamus">@ keithamus</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1916961847" data-permission-text="Title is private"
data-url="chaijs/chai#1540"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1540/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1540">#1540</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/chaijs/chai/compare/v4.3.9...v4.3.10"><tt>v4.3.9...v4.3.10</tt></a></p>
      </li>
      <li>
<b>4.3.9</b> - <a
href="https://snyk.io/redirect/github/chaijs/chai/releases/tag/v4.3.9">2023-09-27</a></br><p>Upgrade
dependencies.</p>
<p>This release upgrades dependencies to address <strong><a
href="https://www.cve.org/CVERecord?id=CVE-2023-43646"
rel="nofollow">CVE-2023-43646</a></strong> where a large function name
can cause "catastrophic backtracking" (aka ReDOS attack) which can cause
the test suite to hang.</p>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/chaijs/chai/compare/v4.3.8...v4.3.9"><tt>v4.3.8...v4.3.9</tt></a></p>
      </li>
      <li>
<b>4.3.8</b> - <a
href="https://snyk.io/redirect/github/chaijs/chai/releases/tag/v4.3.8">2023-08-24</a></br><h2>What's
Changed</h2>
<ul>
<li>4.x.x: Fix link to commit logs on GitHub by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/bugwelle/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/bugwelle">@ bugwelle</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1442318999" data-permission-text="Title is private"
data-url="chaijs/chai#1487"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1487/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1487">#1487</a></li>
<li>build(deps): bump socket.io-parser from 4.0.4 to 4.0.5 by <a
class="user-mention notranslate" data-hovercard-type="organization"
data-hovercard-url="/orgs/dependabot/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/dependabot">@ dependabot</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1442803192" data-permission-text="Title is private"
data-url="chaijs/chai#1488"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1488/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1488">#1488</a></li>
<li>Small typo in test.js by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/mavaddat/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/mavaddat">@ mavaddat</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1154733117" data-permission-text="Title is private"
data-url="chaijs/chai#1459"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1459/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1459">#1459</a></li>
<li>docs: specify return type of objDisplay by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/scarf005/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/scarf005">@ scarf005</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1476032440" data-permission-text="Title is private"
data-url="chaijs/chai#1490"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1490/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1490">#1490</a></li>
<li>Update CONTRIBUTING.md by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/matheus-rodrigues00/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/matheus-rodrigues00">@
matheus-rodrigues00</a> in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1732701131"
data-permission-text="Title is private"
data-url="chaijs/chai#1521"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1521/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1521">#1521</a></li>
<li>Fix: update exports.version to current version by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/peanutenthusiast/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/peanutenthusiast">@
peanutenthusiast</a> in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1864098264"
data-permission-text="Title is private"
data-url="chaijs/chai#1534"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1534/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1534">#1534</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/bugwelle/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/bugwelle">@ bugwelle</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1442318999"
data-permission-text="Title is private"
data-url="chaijs/chai#1487"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1487/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1487">#1487</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mavaddat/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/mavaddat">@ mavaddat</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1154733117"
data-permission-text="Title is private"
data-url="chaijs/chai#1459"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1459/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1459">#1459</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/scarf005/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/scarf005">@ scarf005</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1476032440"
data-permission-text="Title is private"
data-url="chaijs/chai#1490"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1490/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1490">#1490</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/matheus-rodrigues00/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/matheus-rodrigues00">@
matheus-rodrigues00</a> made their first contribution in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1732701131" data-permission-text="Title is private"
data-url="chaijs/chai#1521"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1521/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1521">#1521</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/peanutenthusiast/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/peanutenthusiast">@
peanutenthusiast</a> made their first contribution in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1864098264" data-permission-text="Title is private"
data-url="chaijs/chai#1534"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1534/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1534">#1534</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/chaijs/chai/compare/v4.3.7...v4.3.8"><tt>v4.3.7...v4.3.8</tt></a></p>
      </li>
      <li>
<b>4.3.7</b> - <a
href="https://snyk.io/redirect/github/chaijs/chai/releases/tag/v4.3.7">2022-11-07</a></br><h2>What's
Changed</h2>
<ul>
<li>fix: deep-eql bump package to support symbols comparison by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/snewcomer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/snewcomer">@ snewcomer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1438632532" data-permission-text="Title is private"
data-url="chaijs/chai#1483"
data-hovercard-type="pull_request"
data-hovercard-url="/chaijs/chai/pull/1483/hovercard"
href="https://snyk.io/redirect/github/chaijs/chai/pull/1483">#1483</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/chaijs/chai/compare/v4.3.6...v4.3.7"><tt>v4.3.6...v4.3.7</tt></a></p>
      </li>
      <li>
<b>4.3.6</b> - <a
href="https://snyk.io/redirect/github/chaijs/chai/releases/tag/v4.3.6">2022-01-26</a></br><p>Update
loupe to 2.3.1</p>
      </li>
    </ul>
from <a href="https://snyk.io/redirect/github/chaijs/chai/releases">chai
GitHub release notes</a>
  </details>
</details>


<details>
  <summary><b>Commit messages</b></summary>
  </br>
  <details>
    <summary>Package name: <b>chai</b></summary>
    <ul>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/744a16e1cc4e8a9c6d4499e1e520a0bc4c80ec18">744a16e</a>
4.3.10</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/0ccd823cb3ee6a433156c4e23cc67de79d4f368d">0ccd823</a>
upgrade all dependencies (ethereum#1540)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/923d0a48fc59a910ecee37c85535379520a3e1b6">923d0a4</a>
4.3.9</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/1a0f8872711f64b8353c30ebcfdf0ceeab404bab">1a0f887</a>
make</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/a141e5739ab32ae579cd2df2eb745dbf1375ac27">a141e57</a>
upgrade deps</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/d9ff2c6d3e3f306b8b76e081cc892f42bf551b26">d9ff2c6</a>
4.3.8</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/8d3205b27e706f188f1c4f548d23b989eb60a0db">8d3205b</a>
build</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/b351dc09440e87917f25daa8d49dfb8866efc704">b351dc0</a>
Fix: update exports.version to current version (ethereum#1534)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/1a8247f30dbe0f54268a9748ae673caec75d6bfe">1a8247f</a>
Update CONTRIBUTING.md (ethereum#1521)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/3a8c49a70733ac7f4570925415e9a8544e2ee1c3">3a8c49a</a>
docs: specify return type of objDisplay (ethereum#1490)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/b45512409768514aac931a54da628adf2d27a934">b455124</a>
test: fix typo in test.js (ethereum#1459)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/98f42337562429353e829ebc4f85a00622087fce">98f4233</a>
build(deps): bump socket.io-parser from 4.0.4 to 4.0.5 (ethereum#1488)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/acd16e0033591d849b82f0700fd223072ebf420c">acd16e0</a>
chore: 4.x.x: Fix link to commit logs on GitHub (ethereum#1487)</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/3c947a7f33b021730ea68a52bd15712fe57134be">3c947a7</a>
build</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/775f50958422278933db6efefa1ec2526191e632">775f509</a>
4.3.7</li>
<li><a
href="https://snyk.io/redirect/github/chaijs/chai/commit/8e780b44f321056c960f00b94b4c2aefa3392c21">8e780b4</a>
fix: deep-eql bump package to support symbols comparison (ethereum#1483)</li>
    </ul>

<a
href="https://snyk.io/redirect/github/chaijs/chai/compare/529b8b527ba99454471ac67d6aebca9d96cb5dd9...744a16e1cc4e8a9c6d4499e1e520a0bc4c80ec18">Compare</a>
  </details>
</details>
<hr/>

**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*

For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkMDQzOThiZC0wYzlmLTQyMmEtOGEyZi0yNTQ2NDNjMDY2MDMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQwNDM5OGJkLTBjOWYtNDIyYS04YTJmLTI1NDY0M2MwNjYwMyJ9fQ=="
width="0" height="0"/>

🧐 [View latest project
report](https://app.snyk.io/org/woodpile37/project/3a4e6031-90ad-4f6e-a8f2-e52f97555f14?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/woodpile37/project/3a4e6031-90ad-4f6e-a8f2-e52f97555f14/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/woodpile37/project/3a4e6031-90ad-4f6e-a8f2-e52f97555f14/settings/integration?pkg&#x3D;chai&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

<!---
(snyk:metadata:{"prId":"d04398bd-0c9f-422a-8a2f-254643c06603","prPublicId":"d04398bd-0c9f-422a-8a2f-254643c06603","dependencies":[{"name":"chai","from":"4.3.6","to":"4.3.10"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/woodpile37/project/3a4e6031-90ad-4f6e-a8f2-e52f97555f14?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"3a4e6031-90ad-4f6e-a8f2-e52f97555f14","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":4,"publishedDate":"2023-09-28T09:50:37.566Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assert.deepEqual / expect().to.deep.equal incorrect with Symbols as keys
4 participants