Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: skip empty env variables branch #114

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

rst0git
Copy link
Member

@rst0git rst0git commented Dec 28, 2023

In some cases, processes may remove all environment variables inherited from the parent process (e.g., nginx). This pull request adds a conditional statement to show the environment variables tree branch only when necessary.

In some cases, processes may remove all environment variables inherited
from the parent process (e.g., nginx [1]). This patch adds a condition
to show the corresponding tree branch only when necessary.

[1] https://nginx.org/en/docs/ngx_core_module.html#env

Signed-off-by: Radostin Stoyanov <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ee3bb1) 78.83% compared to head (0d64d08) 78.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   78.83%   78.85%   +0.02%     
==========================================
  Files           6        6              
  Lines         926      927       +1     
==========================================
+ Hits          730      731       +1     
  Misses        154      154              
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Test Results

48 tests  ±0   48 ✅ ±0   1s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 0d64d08. ± Comparison against base commit 4ee3bb1.

Copy link
Collaborator

@behouba behouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianreber adrianreber merged commit 9aa0386 into checkpoint-restore:main Dec 29, 2023
10 checks passed
@rst0git rst0git deleted the tree-env-fix branch December 29, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants