-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make: generate auto-completion files #118
Conversation
We currently have a single line that contains the declarations for all phony targets. As we add new makefile targets, this line becomes increasingly long. Using declarations on separate lines would be easier to maintain. Signed-off-by: Radostin Stoyanov <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 78.85% 78.67% -0.19%
==========================================
Files 6 9 +3
Lines 927 1158 +231
==========================================
+ Hits 731 911 +180
- Misses 154 185 +31
- Partials 42 62 +20 ☔ View full report in Codecov by Sentry. |
Do we need to keep the generated files in the repository? |
I used an approach similar to Podman (https://github.com/containers/podman/tree/main/completions); it simplifies the installation process. With this approach we don't need to generate the auto-completion files every time we build/install checkpointctl, but we can use |
73ab76b
to
eb04e19
Compare
I kind of like it to have information about the completion in the main README file. No need from my side to move it somewhere else. Besides that, this looks good. |
This patch extends the Makefile with targets to generate, install, and uninstall auto-completion files. Signed-off-by: Radostin Stoyanov <[email protected]>
Signed-off-by: Radostin Stoyanov <[email protected]>
Major highlights of this release: - Added annotations for creating OCI images (checkpoint-restore#127) - Added support for list command (checkpoint-restore#115) - Added auto-completion files (checkpoint-restore#118) Signed-off-by: Radostin Stoyanov <[email protected]>
This pull request extends the Makefile with targets to generate, install, and uninstall auto-completion files.