-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotations for creating OCI images from checkpoint archives #127
Conversation
@rst0git @adrianreber Let's first confirm the structure of the annotation. After that, I will add additional annotations for Podman and CRI-O. |
This feels redundant: |
2a29fa0
to
5db2d95
Compare
@adrianreber How should we handle backward comparability with CRI-O and Podman? Do we want to deprecate the old annotations and provide support for them up to specified version, or to simply replace the annotations with a "breaking change". |
For CRI-O it is relatively easy as we only use one annotation. We will just handle both (for some time or forever). For Podman I would personally do the same. No need to break anything for the annotations used by Podman. For the ones not used I would just rename them. |
5db2d95
to
2d0c811
Compare
bea3477
to
1ea9849
Compare
1ea9849
to
820fd58
Compare
@adrianreber PTAL |
820fd58
to
27b455e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 78.73% 78.73%
=======================================
Files 11 11
Lines 1260 1260
=======================================
Hits 992 992
Misses 201 201
Partials 67 67 ☔ View full report in Codecov by Sentry. |
The test failure is unexpected. Seems like some project changed the minimum Go version without changing its version. Strange. I guess we need another PR doing |
@adrianreber I opened one here #133 |
Please rebase. |
- These annotations provide metadata including the container manager, container-name, pod, namespace for creating OCI images from checkpoint archives. Signed-off-by: Parthiba-Hazra <[email protected]>
27b455e
to
1c47bb2
Compare
Major highlights of this release: - Added annotations for creating OCI images (checkpoint-restore#127) - Added support for list command (checkpoint-restore#115) - Added auto-completion files (checkpoint-restore#118) Signed-off-by: Radostin Stoyanov <[email protected]>
These annotations provide metadata including the container manager, container-name, pod, namespace for creating OCI images from checkpoint archives.