Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for two dimensional variables #9

Merged
merged 1 commit into from
Jun 7, 2017
Merged

added support for two dimensional variables #9

merged 1 commit into from
Jun 7, 2017

Conversation

fullergalway
Copy link
Contributor

Hi,

Useful project, thanks.

I wanted to read some ichthyop output files, but encountered a problem retrieving data for the two dimensional lat and lon data variables. I added a test case and resolved.

This may address #6?

Kind regards,
Rob Fuller,
on behalf of Irish Marine Institute

@codecov-io
Copy link

codecov-io commented Jun 1, 2017

Codecov Report

Merging #9 into master will increase coverage by 3.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage    88.1%   91.66%   +3.56%     
==========================================
  Files           5        5              
  Lines         227      228       +1     
  Branches       38       39       +1     
==========================================
+ Hits          200      209       +9     
+ Misses         27       19       -8
Impacted Files Coverage Δ
src/data.js 100% <100%> (ø) ⬆️
src/types.js 84.81% <0%> (+10.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28f2de1...0c95846. Read the comment docs.

@maasencioh
Copy link
Member

Hello @fullergalway,

Thank you so much for your contribution, I also have the impression that is related to it but I'll test if it solves the issue.

@maasencioh maasencioh merged commit 1229241 into cheminfo:master Jun 7, 2017
@maasencioh maasencioh mentioned this pull request Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants