Fixed the regression in addChildNodes (#24)

* Fixed the regression in addChildNodes * wip * rebuilt dist & examples * applied feedback
cheton · Jan 30, 2018 · 0ca1dc1 · 0ca1dc1
1 parent ca7829d
commit 0ca1dc1
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/dist/infinite-tree.js b/dist/infinite-tree.js
@@ -1348,9 +1348,11 @@ var InfiniteTree = function (_events$EventEmitter) {
         } else {
             var parentOffset = this.nodes.indexOf(parentNode);
             if (parentOffset >= 0) {
-                // Update nodes & rows
-                this.nodes.splice.apply(this.nodes, [parentOffset + 1, deleteCount].concat(nodes));
-                this.rows.splice.apply(this.rows, [parentOffset + 1, deleteCount].concat(rows));
+                if (parentNode.state.open === true) {
+                    // Update nodes & rows
+                    this.nodes.splice.apply(this.nodes, [parentOffset + 1, deleteCount].concat(nodes));
+                    this.rows.splice.apply(this.rows, [parentOffset + 1, deleteCount].concat(rows));
+                }
 
                 // Update the row corresponding to the parent node
                 this.rows[parentOffset] = this.options.rowRenderer(parentNode, this.options);

diff --git a/dist/infinite-tree.min.js b/dist/infinite-tree.min.js
diff --git a/docs/examples.js b/docs/examples.js
diff --git a/src/infinite-tree.js b/src/infinite-tree.js
@@ -487,9 +487,11 @@ class InfiniteTree extends events.EventEmitter {
         } else {
             const parentOffset = this.nodes.indexOf(parentNode);
             if (parentOffset >= 0) {
-                // Update nodes & rows
-                this.nodes.splice.apply(this.nodes, [parentOffset + 1, deleteCount].concat(nodes));
-                this.rows.splice.apply(this.rows, [parentOffset + 1, deleteCount].concat(rows));
+                if (parentNode.state.open === true) {
+                    // Update nodes & rows
+                    this.nodes.splice.apply(this.nodes, [parentOffset + 1, deleteCount].concat(nodes));
+                    this.rows.splice.apply(this.rows, [parentOffset + 1, deleteCount].concat(rows));
+                }
 
                 // Update the row corresponding to the parent node
                 this.rows[parentOffset] = this.options.rowRenderer(parentNode, this.options);