Prepare to purge resource API #3574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequencer
force-pushed
the
clean-up-resource-api
branch
3 times, most recently
from
6bc2356 to
315d3f4
Compare
sequencer
force-pushed
the
clean-up-resource-api
branch
from
315d3f4 to
e15b5b7
Compare
jerryz123
reviewed
Feb 26, 2024
jerryz123
reviewed
Feb 26, 2024
jerryz123
reviewed
Feb 26, 2024
sequencer
force-pushed
the
clean-up-resource-api
branch
from
e15b5b7 to
516da16
Compare
jerryz123
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split the traditional Resource Binding out from BareSubsystem, I should not break any dependency on
BaseSubsytem.But for a modern API in the future, I prepare to land the brand new
PropertyAPI in Chisel andOMAPI in CIRCT for metadata processing.