fix: #2171 #2314
Open
fix: #2171 #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fangism
reviewed
Dec 31, 2024
| @@ -35,14 +35,16 @@ struct LintConfigParameterDescriptor { | |||
| std::string description; | |||
| }; | |||
|
|
|||
| struct LintRuleDescriptor { | |||
There was a problem hiding this comment.
Did you mean to delete this?
| } // namespace verilog | ||
|
|
||
| #endif // VERIBLE_VERILOG_ANALYSIS_DESCRIPTIONS_H_ | ||
| std::string format_long_description(const std::string& description) { |
There was a problem hiding this comment.
Is this new function used anywhere? If so, you may declare it in a .h file, but define it in the corresponding .cc file.
There was a problem hiding this comment.
This file doesn't look like it should be added in this PR.
(I'm not familiar with VSCode and how this should work. Perhaps someone else can comment?)
There was a problem hiding this comment.
Are you missing the change to the verilog-preprocess.h that includes the new condition_stack_ class member and AnnotatePreprocessorDirectives method?
| @@ -1035,3 +1035,29 @@ TEST(VerilogPreprocessTest, | |||
|
|
|||
| } // namespace | |||
| } // namespace verilog | |||
|
|
|||
| TEST(PreprocessorAnnotationTest, AnnotatesConditionals) { | |||
There was a problem hiding this comment.
Nice test!
I suggest adding tests to cover ifndef and elsif as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue: #2171