Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#369)(#371) Accessibility for dropdowns, pagination, and maint items #370

Merged
merged 5 commits into from
Jan 10, 2024
Merged

(#369)(#371) Accessibility for dropdowns, pagination, and maint items #370

merged 5 commits into from
Jan 10, 2024

Conversation

st3phhays
Copy link
Member

@st3phhays st3phhays commented Jan 10, 2024 •
edited
Loading

Description Of Changes

  • Increases accessibility for dropdowns and pagination
  • Makes border radius consistent for flatpickr inputs
  • Adds a file to the eslintrc

Motivation and Context

These are all small changes that are needed for the portal.

Testing

  1. Run the site
  2. Select any dropdown and notice the colors are accessible (this is a very slight change to how they were)
  3. Pagination items on tables look very similar as they do on https://community.chocolatey.org/packages
  4. Any flatpickr (date time picker) inputs have rounded corners like other inputs

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #369
Fixes #371

@st3phhays
(chocolatey#369) Accessibility for dropdowns and pagination
c40b6ce 
These updates enhance the accessibility of the dropdowns and pagination
components while keeping everything with the current branding and style.
@st3phhays st3phhays self-assigned this Jan 10, 2024
@st3phhays
(chocolatey#371) Avoid unnecessary scrollbars
44251ed 
This adjusts the left navigation to avoid unnecessary scrollbars by
giving the left navigation a height. After checking that this CSS was
used nowhere else, it has been moved to the specific
_left-navigation.scss file so it is more specific to this situation.
@st3phhays
Use global border radius for flatpickr
666feed 
All inputs have a global border radius applied to them, however the
flatpickr input did not. This adds the global border radius to the
input to make it look consistent with the rest of the inputs.
@st3phhays
(maint) Add additional files to eslintrc
8cf9a92 
This adds an additional folder and file to be linted by eslint.
@st3phhays
Upgrade version to 0.5.20
4e2d779
@st3phhays st3phhays changed the title (#369) Accessibility for dropdowns, pagination, and maint items (#369)(#371) Accessibility for dropdowns, pagination, and maint items Jan 10, 2024
@st3phhays st3phhays requested a review from vexx32 January 10, 2024 20:28
vexx32
vexx32 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work, Steph :3

@vexx32 vexx32 merged commit b070d3a into chocolatey:main Jan 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vexx32 vexx32 vexx32 approved these changes

Assignees

@st3phhays st3phhays

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary scrollbars on left side navigation Enhance Dropdown and Pagination styles for accessibility
2 participants
@st3phhays @vexx32