Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#386) Update autoComplete dropdown #387

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

st3phhays
Copy link
Member

Description Of Changes

This updates the autoComplete dropdown to use <p> elements instead of
<ul> elements. This allows the proper selections to be made in the
dropdown.

Motivation and Context

This bug was causing the wrong package to be search for.

Testing

  1. Run the site.
  2. Search for mar, but do not select anything or press enter.
  3. On your keyboard, press the down arrow. You are taken to the first suggestion.
  4. Click with your mouse on the first suggestion, and you are taken to the correct url. Repeat for other suggestions if wanted.

Operating Systems Testing

n/a

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

This updates the autoComplete dropdown to use `<p>` elements instead of
`<ul>` elements. This allows the proper selections to be made in the
dropdown.
@st3phhays st3phhays self-assigned this Feb 20, 2024
@st3phhays st3phhays requested a review from gep13 February 20, 2024 17:25
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@gep13 gep13 merged commit b10c7c8 into chocolatey:main Feb 21, 2024
2 checks passed
@gep13
Copy link
Member

gep13 commented Feb 21, 2024

@st3phhays thank you very much for getting this fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants