Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#315) Update datatables package #411

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

st3phhays
Copy link
Member

Description Of Changes

This updates the datatables.net library to use the recommended set of
packages needed to display datatables and format them with Bootstrap.
Now, the package is up to date, and repositories that use it have been
updated to use the new syntax.

As a result of the updating of the package, many new files have been added to util/*. This is due to how the new datatables package works, and how integrated it was in other functions. Separating these out will allow usage of them in other projects and to work with the new datatables syntax.

Motivation and Context

This package was broken, and we were stuck on an old version. Updating removes the potential for any security vulnerabilities that would not be patched, and also allows us to use this package on new repositories.

Testing

  1. See repository specific instructions.

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

@st3phhays st3phhays self-assigned this Jul 1, 2024
@st3phhays st3phhays requested a review from vexx32 July 1, 2024 14:34
Copy link
Member

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment here, otherwise the changes themselves here look alright, going to take a look at them in play before I call this all good :3

build/choco-theme.ts Outdated Show resolved Hide resolved
st3phhays added 2 commits July 1, 2024 11:31
This updates the datatables.net library to use the recommended set of
packages needed to display datatables and format them with Bootstrap.
Now, the package is up to date, and repositories that use it have been
updated to use the new syntax.
Copy link
Member

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be good, great work Steph! 💜

@vexx32 vexx32 merged commit 673802c into chocolatey:main Jul 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants