(#425)(#427) Update styles for copenhagen #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes up the nested list styles for the copenhagen theme. Previously these styles were not allowing nested lists, and was making everything, even nested lists, look like one big list with no indentations. Now, everything appears as it should which allows content to be more readable.
This adds styles for the Tab component to the copenhagen theme css. On most repositories, classes are used on the component to define these styles, but, to ease development on this specific repository the styles have been added directly to the css. This is so that examples can be copied directly from the Bootstrap docs, and still be styled up to choco-theme.
st3phhays
force-pushed
the
release/0.8.3
branch
from
6293322 to
55d50f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This commit addresses two style related items. For nested lists, they
will now be displayed as they should, instead of one long list regardless
of their nested status. In addition, styles have been added to allow
the usage and display of the Tab component. This has been structured in
such a way, that the example from the Bootstrap docs can be copied and
used directly. See example directly at:
https://getbootstrap.com/docs/5.3/components/navs-tabs/#javascript-behavior
Motivation and Context
These needed to be fixed up to work correctly.
Testing
Change Types Made
Change Checklist
Related Issue
#425
#427