address PR comments

chromadb/db/clickhouse.py

@@ -446,15 +446,15 @@ def get_nearest_neighbors(
         collection_uuid=None,
     ) -> Tuple[List[List[uuid.UUID]], List[List[float]]]:
 
+        # Either the collection name or the collection uuid must be provided
+        if collection_name == None and collection_uuid == None:
+            raise TypeError("Arguments collection_name and collection_uuid cannot both be None")
+
         if collection_name is not None:
             collection_uuid = self.get_collection_uuid_from_name(collection_name)
 
         self._idx.load_if_not_loaded(collection_uuid)
 
-        # Either the collection name or the collection uuid must be provided
-        if collection_name == None and collection_uuid == None:
-            raise TypeError("Arguments collection_name and collection_uuid cannot both be None")
-
         idx_metadata = self._idx.get_metadata()
         # Check query embeddings dimensionality
         if idx_metadata["dimensionality"] != len(embeddings[0]):

chromadb/test/test_api.py

@@ -35,6 +35,7 @@ def local_persist_api():
         )
     )
 
+# https://docs.pytest.org/en/6.2.x/fixture.html#fixtures-can-be-requested-more-than-once-per-test-return-values-are-cached
 @pytest.fixture
 def local_persist_api_cache_bust():
     return chromadb.Client(
@@ -115,7 +116,10 @@ def test_persist_index_loading(api_fixture, request):
 
     api2 = request.getfixturevalue("local_persist_api_cache_bust")
     collection = api2.get_collection('test')
-    collection.query(query_texts="hello", n_results=1) 
+
+    nn = collection.query(query_texts="hello", n_results=1)
+    for key in nn.keys():
+        assert len(nn[key]) == 1
 
 
 @pytest.mark.parametrize("api_fixture", [local_persist_api])