Convert scripts to Python3 #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarron
approved these changes
Apr 9, 2022
|
1f19c7f made some changes to support python3, so this PR has merge conflicts with that commit. If this PR is still relevant (the .pylintrc and .style.yapf probably still are relevant), can you rebase it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Python scripts in
scripts/to be Python3 compatible, and does some general cleanup. This also adds a new.pylintrcfile and.style.yapffile so pylint and yapf will work and apply the appropriate style guide ("Google Python Style") to make it easier to check style issues in the future. The biggest style change is moving away from printf-style format strings to Pythonf""format strings, and changing one "tricky" way of convincing the JSON parser to handle an object to a slightly different style (and adding a comment).I've tested the updated scripts by manually running
update_bulk_preloaded.pyand by running through the playbook at https://github.com/chromium/hstspreload.org/wiki/Preload-List-Processes#updating-bulk-hsts-entries to testroll_preload_list.py.