Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add repeated test in http ping agent plugin #17

Merged
merged 4 commits into from
Sep 11, 2024
Merged

feat: add repeated test in http ping agent plugin #17

merged 4 commits into from
Sep 11, 2024

Conversation

lunzhou2024
Copy link
Contributor

@lunzhou2024 lunzhou2024 commented Jul 17, 2024 •
edited
Loading

Description

in agent plugin: httpPing add two config params: repeatsWithoutFail and waitBetweenRepeats

  • repeatsWithoutFail is the total repeated http ping test times. If any failure occurs, the final test result will be failed. It conflicts with retries and timeoutRetries.
  • no change to current logic of retries and timeoutRetries.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@bakshi41c
Copy link
Contributor

Can we also add a warning log, if the test is configured to use both retries/timeoutRetries and the new options

@lunzhou2024
Copy link
Contributor Author

Can we also add a warning log, if the test is configured to use both retries/timeoutRetries and the new options

https://github.com/cisco-open/synthetic-heart/pull/17/files#diff-817f7fbcc0100f55117ac3b2988d6fdc8893eda0d48cb6c60ffd6c5f2deae5d2R80

@lunzhou2024 lunzhou2024 changed the title feat: add consecutive test in http ping agent plugin feat: add repeated test in http ping agent plugin Sep 5, 2024
@subbaksh subbaksh merged commit beba465 into cisco-open:main Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subbaksh subbaksh subbaksh approved these changes

@bakshi41c bakshi41c Awaiting requested review from bakshi41c

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lunzhou2024 @bakshi41c @subbaksh